Skip to content
System contracts CI

chore(verifier): update generation to include vk hash #1666

Sign in to view logs

chore(verifier): update generation to include vk hash

chore(verifier): update generation to include vk hash #1666

Triggered via pull request May 13, 2024 21:15
@koloz193koloz193
reopened #453
zk-evm-580-verifiersol-generation-script-should-also-put-the-commitment
Status Success
Total duration 8m 57s
Artifacts –

system-contracts-ci.yaml

on: pull_request
build
1m 33s
build
lint
53s
lint
check-hashes
33s
check-hashes
test-bootloader
7m 4s
test-bootloader
test-contracts
3m 26s
test-contracts
Fit to window
Zoom out
Zoom in

Annotations

15 warnings
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint: l1-contracts/contracts/state-transition/chain-deps/facets/Mailbox.sol#L283
Avoid to use tx.origin
lint: l1-contracts/contracts/upgrades/Upgrade_v1_4_1.sol#L11
Contract name must be in CamelCase
lint: l1-contracts/contracts/vendor/AddressAliasHelper.sol#L55
Avoid to use tx.origin
lint: l1-contracts/test/foundry/unit/concrete/AddressAliasHelper/applyL1ToL2Alias.t.sol#L6
Contract name must be in CamelCase
lint: l1-contracts/test/foundry/unit/concrete/AddressAliasHelper/undoL1ToL2Alias.t.sol#L6
Contract name must be in CamelCase
lint: l1-contracts/test/foundry/unit/concrete/Executor/ExecutorProof.t.sol#L2
Found more than One contract per file. 2 contracts found!
lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/DiamondProxy/DiamondProxy.t.sol#L2
Found more than One contract per file. 2 contracts found!
lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Admin/ExecuteUpgrade.t.sol#L3
Found more than One contract per file. 2 contracts found!
lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Base/_Base_Shared.t.sol#L2
Found more than One contract per file. 2 contracts found!
lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Getters/_Getters_Shared.t.sol#L2
Found more than One contract per file. 2 contracts found!
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/cache/save@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
check-hashes
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/cache/restore@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
test-contracts
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/cache/restore@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
test-bootloader
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache/restore@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.