Fixed loadtest configuration #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed configuring TCP ports.
Removed builder methods from the config, because the defaults were the cause of a malformed config in the first place.
Moved rpc_addr (renamed to debug_addr) to config, and removed the default port logic - opening a port which was not predeclared on the gcp VM spec made the whole container crash.
Added support for disabling the test rpc server if not needed.
Increased disk size for the loadtest CI to fit 3h worth of finalized blocks.
Simplified CLI api of
tool/src/main.rs: embedded the secrets into the config json.Some kubernetes/docker-related scripts probably need an update.