Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test RPC layer for Standalone Node (BFT-396) #59

Merged
merged 55 commits into from
Feb 5, 2024
Merged

Conversation

IAvecilla
Copy link
Contributor

@IAvecilla IAvecilla commented Jan 19, 2024

What ❔

Introduce an RPC layer for the Standalone node, including a test server featuring an endpoint for health-checking the node, and a CLI client for making requests to this server.

Why ❔

This layer becomes necessary for communication with nodes within a cluster, especially for running tests that involve communication with these nodes. Additionally, it could serve as the initial implementation for a signaling or communication system within the test module, facilitating the determination of test success or failure.

IAvecilla and others added 30 commits January 10, 2024 18:34
Co-authored-by: Bruno França <[email protected]>
@IAvecilla IAvecilla marked this pull request as ready for review February 1, 2024 23:12
@IAvecilla
Copy link
Contributor Author

@pompon0 I think there's some issues with cargo-deny probably because of the new jsonrpsee crate. LMK if you want me to change the deny.toml of you want another way to solve this kind of issues.

@brunoffranca
Copy link
Member

brunoffranca commented Feb 2, 2024

The offending crate seems to be ring. It has a non-standard license so cargo deny can't read it. It's enough to just clarify the license in the deny.toml file. See licenses.clarify in the configuration (funnily enough, the example they give is the ring crate).

@pompon0 pompon0 self-requested a review February 2, 2024 10:47
@pompon0
Copy link
Collaborator

pompon0 commented Feb 2, 2024

please fix the license warning, just like Bruno said. Please fix the "multiple crate versions" warning by upgrading the crate versions in Cargo.toml where feasible. For the rest of packages, add the old versions to the deny.toml following the examples that we already have there.

@IAvecilla
Copy link
Contributor Author

I managed to fix it by only adding the older versions of the conflicting crates. I didn't include the license for the ring crate since I didn't see any warning for that. Additionally, I removed an old version of itertools that was causing a warning.

@pompon0 pompon0 merged commit b204fb3 into main Feb 5, 2024
4 checks passed
@pompon0 pompon0 deleted the rpc_test_layer branch February 5, 2024 14:02
@brunoffranca brunoffranca changed the title Test RPC layer for Standalone Node Test RPC layer for Standalone Node (BFT-396) Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants