-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make consensus state machine asynchronous (BFT-406) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshababo
changed the title
(WIP) Make consensus state machine asynchronous (BFT-406)
Make consensus state machine asynchronous (BFT-406)
Jan 16, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approach lg in general, I've added comments about conventions and expected usage of structured concurrency. The important comment is the one about pruning semantics which won't work as is, but should be easy to fix.
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 17, 2024
pompon0
reviewed
Jan 22, 2024
pompon0
reviewed
Jan 22, 2024
pompon0
reviewed
Jan 22, 2024
pompon0
reviewed
Jan 22, 2024
pompon0
reviewed
Jan 22, 2024
pompon0
reviewed
Jan 22, 2024
pompon0
reviewed
Jan 22, 2024
pompon0
reviewed
Jan 24, 2024
pompon0
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
leader
being unable to block colocatedreplica
(and vise versa).Main changes
sync::prunable_mpsc
module has been added to provide a channel-like FIFO queue with additional functionality for removal of specific pending values.replica
/leader
), which consumes corresponding messages from the inbound queue. Top-level processing includes onlysend()
operation, without waiting for the processing response.Follow-up: