Improvements on standalone node execution (BFT-399) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
reviewed
Jan 9, 2024
node/tools/src/main.rs
Outdated
| let database_path = if let Some((consensus_config, _)) = &configs.consensus { | ||
| Path::new("database").join(consensus_config.public_addr.to_string()) | ||
| } else { | ||
| Path::new("database").join(configs.executor.server_addr.to_string()) |
There was a problem hiding this comment.
fyi, "database" is a flag now
There was a problem hiding this comment.
I've already merged the main branch with the latest changes, so it should be up-to-date now. I also noticed a modification in the logger initialization, it's currently logging only the ERROR events. I added the necessary environment variable for logging INFO events in the makefile within this commit 9a0d514 and updated the code comment about the logger in this one c1a4653. Let me know if this change was intentional, or if you'd like me to revert it back to logging for the info level by default.
There was a problem hiding this comment.
that was intentional, thx for updating the comment
pompon0
reviewed
Jan 9, 2024
pompon0
reviewed
Jan 9, 2024
pompon0
reviewed
Jan 9, 2024
pompon0
approved these changes
Jan 9, 2024
brunoffranca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Documented a guide on setting up and running a local consensus node, along with a new Makefile containing commands for easy execution. Also modifies the database directory path for each node.
Why ❔
The README and the Makefile would streamline generating the configuration for all nodes with a single command and simplify running the desired node. About the modification for the database directory path, it seems beneficial for running multiple nodes on a single machine, especially for local testing. However, in the broader architecture of the Test Framework, each node is expected to operate within a distinct Docker container or a similar setup. In that context, this change might not be useful.