made bft actor send LeaderPrepare messages asynchronously (BFT-400) #52
Conversation
pompon0
changed the title
| else { | ||
| return Ok(()); | ||
| }; | ||
| debug_assert!(replica_messages.len() == self.inner.threshold()); |
There was a problem hiding this comment.
Just to understand: Is strict equality instead of >= intended here? The find predicate above implies >=. If the strict equality is intended, you can use debug_assert_eq; it'll provide more informative panic message.
There was a problem hiding this comment.
we want ==, to make sure that we don't wait for too many signatures.
There was a problem hiding this comment.
this is a debug_assert, because it would be technically correct to include more signatures.
There was a problem hiding this comment.
I'm not satisfied with this design. It's a bit of a quick fix, I think it does decrease the readability of the code.
Also, looking at the future here, besides wanting to send LeaderPrepare messages asynchronously, we probably want to send asynchronously ReplicaCommit messages (because we need to verify the proposals and that might block) and ReplicaPrepare (when we implement the consensus oracle we will need to fetch external information, again might block). The only that doesn't need to be asynchronous is LeaderCommit.
I would prefer then that each of these messages are handled by a separate background task, and ideally without separating the message processing.
|
@moshababo Take a look. You're a code owner for this actor now too. |
Co-authored-by: Bruno França <[email protected]>
What ❔
Made bft actor send LeaderPrepare messages asynchronously.
Why ❔
PayloadSource.propose() may be blocking (when no payload can be proposed at a time) but it shouldn't block message processing: