Switch from ark-bn254 to matterlabs/pairing (BFT-325) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # node/Cargo.lock # node/libs/crypto/src/bn254/tests.rs
brunoffranca
changed the title
slowli
reviewed
Nov 9, 2023
# Conflicts: # node/Cargo.lock # node/deny.toml # node/libs/crypto/Cargo.toml # node/libs/crypto/src/bn254/hash.rs
|
Pending matter-labs/pairing#11 to be merged. |
moshababo
changed the title
pompon0
reviewed
Nov 9, 2023
pompon0
reviewed
Nov 9, 2023
pompon0
reviewed
Nov 9, 2023
brunoffranca
previously approved these changes
Nov 9, 2023
slowli
reviewed
Nov 10, 2023
node/libs/crypto/src/bn254/mod.rs
Outdated
| @@ -25,52 +27,66 @@ pub mod hash; | |||
| mod testonly; | |||
|
|
|||
| /// Type safety wrapper around a scalar value. | |||
| #[derive(Debug, PartialEq)] | |||
There was a problem hiding this comment.
Since SecretKey is sensitive information, it makes sense to manually define Debug so that it only outputs the corresponding public key.
There was a problem hiding this comment.
use other private key types in crypto crate as example
There was a problem hiding this comment.
Fixed here: d0eeea4
| .map(Self) | ||
| .context("failed to decode secret key") | ||
| let mut fr_repr = FrRepr::default(); | ||
| fr_repr.read_be(Cursor::new(bytes))?; |
There was a problem hiding this comment.
- Nit:
Cursoris not strictly necessary here;std::io::Readis implemented for&mut &[u8]as well (i.e., a shared reference to bytes, where the reference itself can change). Thus, you can declaremut bytes: &[u8]and callfr_repr.read_be(&mut bytes)and maybe check that all bytes were read. - Is big-endian encoding canonical for BN254 (i.e., used in other implementations)? Or is there no convention? I'm not entirely sure, but the
arkimplementation looks little-endian, although the Go one by Consensys is big-endian.
There was a problem hiding this comment.
- Nit:
Cursoris not strictly necessary here;std::io::Readis implemented for&mut &[u8]as well (i.e., a shared reference to bytes, where the reference itself can change). Thus, you can declaremut bytes: &[u8]and callfr_repr.read_be(&mut bytes)and maybe check that all bytes were read.
Right it's not necessary. Simply removing it seems to be enough.
- Is big-endian encoding canonical for BN254 (i.e., used in other implementations)? Or is there no convention? I'm not entirely sure, but the
arkimplementation looks little-endian, although the Go one by Consensys is big-endian.
I'm not sure, but I don't think that there is a convention regarding the endianness.
pompon0
reviewed
Nov 10, 2023
node/libs/crypto/src/bn254/mod.rs
Outdated
| @@ -25,52 +27,66 @@ pub mod hash; | |||
| mod testonly; | |||
|
|
|||
| /// Type safety wrapper around a scalar value. | |||
| #[derive(Debug, PartialEq)] | |||
There was a problem hiding this comment.
Don't implement PartialEq for private key. Always compare corresponding public keys instead.
There was a problem hiding this comment.
What about this: e3074cb?
brunoffranca
approved these changes
Nov 10, 2023
brunoffranca
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching bn254 implementation from crates/ark-bn254 to matter-labs/pairing due to compatibility issues of zksync-era with the former.
Notes:
bn254::tests::byte_fmt_correctnesstests were added, previously not coveredTODO:
bn254::tests::aggregate_signature_distinct_messagesis failing, need to figure out whypairingdependency was redirected to a fork, due to missing functionality. If no other solution is found, it should be merged to upstream and dependency to be redirected backbn254::testonly: need to find a solution forrand::Rng (rand = "0.8.0")trait object incompatibility withrand04::Rng (rand = "0.4.6")trait bound