Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix load testing workflow #22

Merged
merged 28 commits into from
Nov 9, 2023
Merged

ci: Fix load testing workflow #22

merged 28 commits into from
Nov 9, 2023

Conversation

hatemosphere
Copy link
Member

@hatemosphere hatemosphere commented Nov 2, 2023 •
edited
Loading

What

  • Pins Ansible Python deps
  • Adds explicit OS Login to GCP instances to not rely on project metadata propagation
  • Adds some extra error handling to Ansible inventory parsing
  • Changes workflow inputs to be PR trigger friendly (to simplify the debug)

Why

  • To fix and improve load testing GHA workflow reliability

@hatemosphere hatemosphere marked this pull request as ready for review November 9, 2023 09:59
@pompon0 pompon0 self-requested a review November 9, 2023 16:07
@brunoffranca brunoffranca merged commit 745780a into main Nov 9, 2023
4 checks passed
@brunoffranca brunoffranca deleted the fix-load-testing branch November 9, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoffranca brunoffranca brunoffranca approved these changes

@pompon0 pompon0 pompon0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hatemosphere @pompon0 @brunoffranca @otani88