-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ChonkyBFT logic #210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c more closely and it greatly simplifies verification.
brunoffranca
force-pushed
the
bf-chonky-logic
branch
from
October 25, 2024 01:48
ad7b440
to
46cebff
Compare
brunoffranca
commented
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
pompon0
reviewed
Oct 30, 2024
One thing I wanted to note is that I don't actually check anywhere that reproposals don't have a payload set. This technically is not necessary since the consensus just ignores the payload. But maybe we want to do that check anyway. |
Yes, for defence in depth, please check that payload is included if and only if it is required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of BFT-452