bumped capability ID of the push_batch_votes rpc #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
approved these changes
Aug 5, 2024
|
we have a test for this, but you can always forget to add the ID to the test |
aakoshh
reviewed
Aug 5, 2024
| @@ -48,7 +48,7 @@ const MAX_PAYLOAD_LEN: usize = MAX_TRANSPORT_MSG_LEN - AUTHDATA_LEN; | |||
| /// <frame len:u16> ++ <frame data:[u8;len]>. | |||
| /// | |||
| /// Length of the frame len field. | |||
| const LENGTH_FIELD_LEN: usize = std::mem::size_of::<u16>(); | |||
There was a problem hiding this comment.
It looks like zksync-era doesn't like this: https://github.com/matter-labs/zksync-era/actions/runs/10249428261/job/28352782628?pr=2583
Not sure I should be bumping the rust-toolchain in my PR.
pompon0
pushed a commit
that referenced
this pull request
Aug 5, 2024
## What ❔ Created a `rust-toolchain` file pinning it to the stable version when 1.79 was released. Reverted the change to `stream.rs` brought about by 1.80 in #176 Bumps the version to `0.1.0-rc.8` ## Why ❔ Because the `zksync-era` build [doesn't work](https://github.com/matter-labs/zksync-era/actions/runs/10249428261/job/28352782628?pr=2583) with `size_of` without qualification like `core::mem::` or `std::mem::`. `zksync-era` is pinned at `nightly-2024-05-07` at the moment. I tried to update it to the last nightly where it was still Rust 1.80, which was `nightly-2024-06-08` but it cannot compile `boojum`, nor does it compile with a later nightly I tried where it's already Rust 1.82.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added an extra field to the Batch message, without considering the fact that an extra field won't be recognized by old binaries and they will fail to verify signatures on Batch messages. They will consider sending such invalid signatures malicious and will disconnect from the peer. To avoid this we create a new RPC instead (by just bumping the capability id on push_batch_votes RPC) which will not be interpreted by the old binaries at all.