improve: AttestationStatusWatch::next_batch_to_attest non-optional (BFT-496) #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
changed the title
…usRunner::init will set it
aakoshh
force-pushed
the
bft-496-no-none-in-status
branch
from
ef5922d
to
824e88a
Compare
pompon0
approved these changes
Jul 31, 2024
brunoffranca
pushed a commit
that referenced
this pull request
Aug 2, 2024
## What ❔ `AttestationRunner::init` should not try to initialise the `AttestationStatus` from the API. Let it be `None` and do the init in the background. This is partially undoing what #165 did. ## Why ❔ The rollout procedure to mainnet was that the EN goes first, then the main node. The EN cannot start without the main node API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
AttestationStatusWatchmust be initialised with aBatchNumber, it cannot haveNoneany more.AttestationStatusRunner::newwas replaced with theAttestationStatusRunner::initmethod which asynchronously polls the API until the first value is returned, and then returns itself along with theAttestationStatusWatchit created. This can then be passed to theExecutor, while theAttestationStatusRunner::runwill keep the status up to date in the background.Why ❔
In the review of #161 it was observed that the
Executorcan wait until this data is available. In theory it is only unavailable if the main node API is down, in which case an external node couldn't pull Genesis either and would probably fail during startup, or if the Genesis itself is still under construction in the database, which is a transient state under which an external node as mentioned would not start, and apparently the main node doesn't need theExecutorto get over it. By removingNoneas an option fornext_batch_to_attestthe state is easier to reason about.