feat: Rework consensus storage crate #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
reviewed
Oct 23, 2023
pompon0
reviewed
Oct 23, 2023
| s.spawn_blocking(|| { | ||
| consensus.replica.start_new_view(ctx, &consensus.inner); | ||
| Ok(()) | ||
| }) |
There was a problem hiding this comment.
nit: we might want to introduce some syntax sugar for this construction.
pompon0
reviewed
Oct 23, 2023
pompon0
reviewed
Oct 23, 2023
pompon0
reviewed
Oct 23, 2023
brunoffranca
previously approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Looks good. I only had a couple of minor questions. Also, I would suggest organizing the storage crate a bit differently to make stuff easier to find:
- Moving all the traits into a traits.rs file.
- Moving RocksdbStorage and all it's methods/implementations into a rocksdb.rs file.
pompon0
reviewed
Oct 23, 2023
brunoffranca
approved these changes
Oct 24, 2023
pompon0
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Part of preparations for the integration with the server codebase.