Improve get addrs (#69)

## What ❔
Fixes
https://linear.app/matterlabs/issue/BFT-429/improve-get-seed-node-addrs-function
Created a `ConsensusNode` struct to handle the internals of a k8s
running node as well as its temporary configuration

## Why ❔

The idea is to have a more object oriented code as stated in a comment
in main [k8s deployment script
PR](#62 (comment))
Also, this `ConsensusNode` struct will be useful to handle the whole
node configurations set for
https://linear.app/matterlabs/issue/BFT-427/provide-full-config-as-a-cli-argument

---------

Co-authored-by: IAvecilla <[email protected]>
Co-authored-by: Nacho Avecilla <[email protected]>
Co-authored-by: Bruno França <[email protected]>
Co-authored-by: Grzegorz Prusak <[email protected]>

node/Cargo.toml

@@ -81,7 +81,6 @@ test-casing = "0.1.0"
 thiserror = "1.0.40"
 time = "0.3.23"
 tokio = { version = "1.34.0", features = ["full"] }
-tokio-retry = "0.3.0"
 tracing = { version = "0.1.37", features = ["attributes"] }
 tracing-subscriber = { version = "0.3.16", features = ["env-filter", "fmt"] }
 kube = { version = "0.88.1", features = ["runtime", "derive"] }

node/tools/Cargo.toml

@@ -26,7 +26,6 @@ rocksdb.workspace = true
 serde.workspace = true
 serde_json.workspace = true
 tokio.workspace = true
-tokio-retry.workspace = true
 tracing.workspace = true
 tracing-subscriber.workspace = true
 vise-exporter.workspace = true

node/tools/src/bin/deployer.rs

@@ -1,13 +1,12 @@
 //! Deployer for the kubernetes cluster.
-use std::net::SocketAddr;
-use std::str::FromStr;
+use std::collections::HashMap;
 use std::{fs, path::PathBuf};
 
 use anyhow::Context;
 use clap::{Parser, Subcommand};
 use zksync_consensus_crypto::{Text, TextFmt};
 use zksync_consensus_roles::{node, validator};
-use zksync_consensus_tools::{k8s, AppConfig, NodeAddr, NODES_PORT};
+use zksync_consensus_tools::{k8s, AppConfig};
 
 /// K8s namespace for consensus nodes.
 const NAMESPACE: &str = "consensus";
@@ -94,54 +93,79 @@ fn generate_config(nodes: usize) -> anyhow::Result<()> {
 }
 
 /// Deploys the nodes to the kubernetes cluster.
-async fn deploy(nodes: usize, seed_nodes: Option<usize>) -> anyhow::Result<()> {
+async fn deploy(nodes_amount: usize, seed_nodes_amount: Option<usize>) -> anyhow::Result<()> {
     let client = k8s::get_client().await?;
     k8s::create_or_reuse_namespace(&client, NAMESPACE).await?;
-
-    let seed_nodes = seed_nodes.unwrap_or(1);
-
-    // deploy seed peer(s)
-    for i in 0..seed_nodes {
-        k8s::deploy_node(
-            &client,
-            i,
-            true,
-            vec![], // Seed peers don't have other peer information
-            NAMESPACE,
-        )
-        .await?;
+    let seed_nodes_amount = seed_nodes_amount.unwrap_or(1);
+
+    let seed_nodes = &mut HashMap::new();
+    let mut non_seed_nodes = HashMap::new();
+
+    // Split the nodes in different hash maps as they will be deployed at different stages
+    let mut consensus_nodes = from_configs(nodes_amount)?;
+    for (index, node) in consensus_nodes.iter_mut().enumerate() {
+        if index < seed_nodes_amount {
+            node.is_seed = true;
+            seed_nodes.insert(node.id.to_owned(), node);
+        } else {
+            non_seed_nodes.insert(node.id.to_owned(), node);
+        }
     }
 
-    // obtain seed peer(s) IP(s)
-    let peer_ips = k8s::get_seed_node_addrs(&client, seed_nodes, NAMESPACE).await?;
-
-    let mut peers = vec![];
+    // Deploy seed peer(s)
+    for node in seed_nodes.values_mut() {
+        node.deploy(&client, NAMESPACE).await?;
+    }
 
-    for i in 0..seed_nodes {
-        let node_id = &format!("consensus-node-{i:0>2}");
-        let node_key = read_node_key_from_config(node_id)?;
-        let address = peer_ips.get(node_id).context("IP address not found")?;
-        peers.push(NodeAddr {
-            key: node_key.public(),
-            addr: SocketAddr::from_str(&format!("{address}:{NODES_PORT}"))?,
-        });
+    // Fetch and complete node addrs into seed nodes
+    for node in seed_nodes.values_mut() {
+        node.fetch_and_assign_pod_ip(&client, NAMESPACE).await?;
     }
 
-    // deploy the rest of nodes
-    for i in seed_nodes..nodes {
-        k8s::deploy_node(&client, i, false, peers.clone(), NAMESPACE).await?;
+    // Build a vector of seed peers NodeAddrs to provide as gossip_static_outbound to the rest of the nodes
+    let peers: Vec<_> = seed_nodes
+        .values()
+        .map(|n| {
+            n.node_addr
+                .as_ref()
+                .expect("Seed node address not defined")
+                .clone()
+        })
+        .collect();
+
+    // Deploy the rest of the nodes
+    for node in non_seed_nodes.values_mut() {
+        node.gossip_static_outbound = peers.clone();
+        node.deploy(&client, NAMESPACE).await?;
     }
 
     Ok(())
 }
 
-/// Obtain node key from config file.
-fn read_node_key_from_config(node_id: &String) -> anyhow::Result<node::SecretKey> {
+/// Build ConsensusNodes representation list from configurations
+// TODO once we can provide config via cli args, this will be replaced
+//      using in-memory config structs
+fn from_configs(nodes: usize) -> anyhow::Result<Vec<k8s::ConsensusNode>> {
     let manifest_path = std::env::var("CARGO_MANIFEST_DIR")?;
     let root = PathBuf::from(manifest_path).join("k8s_configs");
-    let node_key_path = root.join(node_id).join("node_key");
-    let key = fs::read_to_string(node_key_path).context("failed reading file")?;
-    Text::new(&key).decode().context("failed decoding key")
+    let mut consensus_nodes = vec![];
+
+    for i in 0..nodes {
+        let node_id = format!("consensus-node-{i:0>2}");
+        let node_key_path = root.join(&node_id).join("node_key");
+        let key_string = fs::read_to_string(node_key_path).context("failed reading file")?;
+        let key = Text::new(&key_string)
+            .decode()
+            .context("failed decoding key")?;
+        consensus_nodes.push(k8s::ConsensusNode {
+            id: node_id,
+            key,
+            node_addr: None,
+            is_seed: false,
+            gossip_static_outbound: vec![],
+        });
+    }
+    Ok(consensus_nodes)
 }
 
 #[tokio::main]