Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve static type checking #223

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Improve static type checking #223

merged 3 commits into from
Apr 30, 2021

Conversation

kibablu
Copy link
Contributor

@kibablu kibablu commented Apr 29, 2021

Add type annotation to json_encode Function on apnstruncate.py file

Add type annotation to json_encode Function on apnstruncate.py file

fixes #201

Signed-off-by: Omar Mohamed <[email protected]>
Copy link
Contributor

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, there's one small change to make but overall it looks good to me :)
I'm also going to edit the PR description so it doesn't accidentally close #201 (since this is only addressing part of the issue).

sygnal/apnstruncate.py Outdated Show resolved Hide resolved
Add type annotation to json_encode Function on apnstruncate.py file

fixes #201

Signed-off-by: Omar Mohamed <[email protected]>
Copy link
Contributor

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks again for your contribution :)

@babolivier babolivier merged commit f6c635a into matrix-org:master Apr 30, 2021
@kibablu kibablu deleted the json_encodeFunction branch April 30, 2021 11:08
@kibablu
Copy link
Contributor Author

kibablu commented Apr 30, 2021

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants