Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge hotfix branch into main #200

Merged
merged 35 commits into from
Jul 12, 2023
Merged

Merge hotfix branch into main #200

merged 35 commits into from
Jul 12, 2023

Commits on Jun 22, 2023

  1. Track the time before processing a request

    in particular load() and setupConnection()
    David Robertson committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    cc8e6d9 View commit details
    Browse the repository at this point in the history
  2. Track the number of slow requests

    David Robertson committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    048a5ac View commit details
    Browse the repository at this point in the history
  3. Update tests

    David Robertson committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    1d46a30 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #183 from matrix-org/dmr/setup-metrics

    Track the time before processing a request
    David Robertson authored Jun 22, 2023
    Configuration menu
    Copy the full SHA
    bdcffda View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Log device ID after requests

    David Robertson committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    2829a7a View commit details
    Browse the repository at this point in the history
  2. Record user and device on context ASAP

    David Robertson committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    f4e935c View commit details
    Browse the repository at this point in the history
  3. Log warning for slow requests

    David Robertson committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    b47ebaa View commit details
    Browse the repository at this point in the history
  4. Merge pull request #184 from matrix-org/dmr/more-debugging

    More slow request debugging
    David Robertson authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    685ec94 View commit details
    Browse the repository at this point in the history
  5. Additional debugging

    David Robertson committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    a8d4f7a View commit details
    Browse the repository at this point in the history
  6. Fix bad backport

    David Robertson committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    a78612e View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Rate limit pubsub.V2DeviceData updates to be at most 1 per second

    The db writes are still instant, but the notifications are now delayed
    by up to 1 second, in order to not swamp the pubsub channels.
    kegsay committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    f36c038 View commit details
    Browse the repository at this point in the history
  2. kick ci?

    kegsay committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    0caeb03 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    82c21e6 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Add WorkerPool and use it for OnE2EEData

    - Allowing unlimited concurrency on OnE2EEData causes huge spikes in DB conns
      when device lists change.
    - Using a high, bounded amount of concurrency ensure we don't breach DB conn limits.
    
    With unit tests.
    kegsay committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    b9bc83d View commit details
    Browse the repository at this point in the history
  2. Merge pull request #190 from matrix-org/kegan/bound-db-conns-e2ee-data

    Add WorkerPool and use it for OnE2EEData
    kegsay authored Jun 28, 2023
    Configuration menu
    Copy the full SHA
    b2ac518 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. bugfix: prevent clients starving themselves by constantly changing re…

    …q params
    
    Because the proxy services changes to req params preferentially to live
    data, if the client constantly changes the window (e.g due to spidering)
    then it can accidentally stop the delivery of live events to the client
    until the spidering process is complete. To help address this, we now
    process live updates _even if_ we have some data to send to the client.
    This is bounded in size to prevent the inverse happening: constantly
    seeing new live events which starves changes to req params. This should
    hopefully strike the right balance.
    
    With regression test.
    kegsay committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    0342a99 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    54cb2cb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aaea223 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0c95c56 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. More trace logging

    kegsay committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    8336dd2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e22f30e View commit details
    Browse the repository at this point in the history
  3. nil checks

    kegsay committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    365ed4c View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Add more poller metrics

    kegsay committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    e67ba9a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7621aa1 View commit details
    Browse the repository at this point in the history
  3. Track num_devices_pending_ensure_polling per device not per http req …

    …as it's more useful this way
    kegsay committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    4d8f3d5 View commit details
    Browse the repository at this point in the history
  4. Add unregister hooks

    kegsay committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    150821f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f22ef91 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Report a metric for the size of gappy state blocks

    David Robertson committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    41a7240 View commit details
    Browse the repository at this point in the history
  2. Log error message to stdout if poller panics

    otherwise we only see the error message if we're using sentry.
    David Robertson committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    5064f64 View commit details
    Browse the repository at this point in the history
  3. Actually observe the new metric

    David Robertson committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    dcf8db3 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #194 from matrix-org/dmr/metric-for-gappy-state

    Report a metric for the size of gappy state blocks
    David Robertson authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    ea25b81 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Configuration menu
    Copy the full SHA
    e947612 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Configuration menu
    Copy the full SHA
    b72ad3b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #198 from matrix-org/kegan/fix-backfill-invite

    Fix #192: ignore unseen old events
    kegsay authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    7380273 View commit details
    Browse the repository at this point in the history
  3. Review comments

    kegsay committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c1b0f0b View commit details
    Browse the repository at this point in the history