This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
Stop the composer being re-initialised when customSuggestionPatterns change #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1027 +/- ##
==========================================
- Coverage 90.14% 89.42% -0.73%
==========================================
Files 179 104 -75
Lines 21627 18152 -3475
Branches 292 291 -1
==========================================
- Hits 19496 16232 -3264
+ Misses 2128 1917 -211
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
t3chguy
approved these changes
Jul 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
customSuggestionPatternschanging was causing the composer to be re-initialised.This was causing tests in the react-sdk to be flakey as the input happens right after initialisation, and some characters were being lost.
Moving the setting of customSuggestionPatterns to it's own effect.