Use the new authenticated endpoints in MediaProxy #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
reviewed
Sep 5, 2024
| @@ -147,7 +147,12 @@ export class MediaProxy { | |||
| } | |||
| // Cache from this point onwards. | |||
| // Extract the media from the event. | |||
| const url = this.matrixClient.mxcToHttp('mxc://' + metadata.mxc); | |||
| const mxcMatch = metadata.mxc.match(new RegExp('^([^/]+)/(.+)$')); | |||
There was a problem hiding this comment.
Assume we have tests that cover this :)
There was a problem hiding this comment.
Manual ones, I'm afraid – our tests never get deep enough to hit onMediaRequest.
I can pull this out into a module and test it there.
Half-Shot
approved these changes
Sep 5, 2024
tadzik
force-pushed
the
tadzik/use-authenticated-endpoints-in-mediaproxy
branch
from
b2ce852
to
afdfd30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the requests failing in matrix-org/matrix-appservice-irc#1816