Trace/replay llms.internal.sendRequest
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To decouple `texampleTests.m` from availability and speed of external servers, record calls to `llms.internal.sendRequest` (on dev machine) and replay (during most test runs, including CI). See tests/recording/README.md for instructions.
ccreutzi
requested review from
adulai,
debymf,
MiriamScharnke and
vpapanasta
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
=======================================
Coverage 97.10% 97.10%
=======================================
Files 40 41 +1
Lines 1347 1348 +1
=======================================
+ Hits 1308 1309 +1
Misses 39 39 ☔ View full report in Codecov by Sentry. |
MiriamScharnke
approved these changes
Aug 5, 2024
vpapanasta
approved these changes
Aug 5, 2024
adulai
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To decouple
texampleTests.mfrom availability and speed of external servers, record calls tollms.internal.sendRequest(on dev machine) and replay (during most test runs, including CI). See tests/recording/README.md for instructions.