Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure api version tests #46

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Azure api version tests #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2666f5f
Update tazureChat.m
vpapanasta Jun 26, 2024
be06d88
Update tazureChat.m
vpapanasta Jun 26, 2024
4cd9047
Update tazureChat.m
vpapanasta Jun 27, 2024
fbf1372
Fix azureChat issue with APIVersion, Endpoint and Deployment arguments
vpapanasta Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions azureChat.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,11 @@
function this = azureChat(systemPrompt, nvp)
arguments
systemPrompt {llms.utils.mustBeTextOrEmpty} = []
nvp.Endpoint {mustBeNonzeroLengthTextScalar}
nvp.Deployment {mustBeNonzeroLengthTextScalar}
nvp.Endpoint (1,1) string {mustBeNonzeroLengthTextScalar}
nvp.Deployment (1,1) string {mustBeNonzeroLengthTextScalar}
nvp.APIKey {mustBeNonzeroLengthTextScalar}
nvp.Tools (1,:) {mustBeA(nvp.Tools, "openAIFunction")} = openAIFunction.empty
nvp.APIVersion (1,1) {mustBeAPIVersion} = "2024-02-01"
nvp.APIVersion (1,1) string {mustBeAPIVersion} = "2024-02-01"
nvp.Temperature {llms.utils.mustBeValidTemperature} = 1
nvp.TopP {llms.utils.mustBeValidTopP} = 1
nvp.StopSequences {llms.utils.mustBeValidStop} = {}
Expand Down
18 changes: 18 additions & 0 deletions tests/tazureChat.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
InvalidGenerateInput = iGetInvalidGenerateInput;
InvalidValuesSetters = iGetInvalidValuesSetters;
StringInputs = struct('string',{"hi"},'char',{'hi'},'cellstr',{{'hi'}});
APIVersions = iGetAPIVersions();
end

methods(Test)
Expand Down Expand Up @@ -150,6 +151,19 @@ function keyNotFound(testCase)
unsetenv("AZURE_OPENAI_API_KEY");
testCase.verifyError(@()azureChat, "llms:keyMustBeSpecified");
end

function canUseAPIVersions(testCase, APIVersions)
% Test that we can use different APIVersion value to call
% azureChat.generate

testCase.assumeTrue(isenv("AZURE_OPENAI_API_KEY"),"end-to-end test requires environment variables AZURE_OPENAI_API_KEY, AZURE_OPENAI_ENDPOINT, and AZURE_OPENAI_DEPLOYMENT.");
chat = azureChat("APIVersion", APIVersions);

response = testCase.verifyWarningFree(@() generate(chat,"How similar is the DNA of a cat and a tiger?"));
testCase.verifyClass(response,'string');
testCase.verifyGreaterThan(strlength(response),0);

end
end
end

Expand Down Expand Up @@ -446,3 +460,7 @@ function keyNotFound(testCase)
"Input",{{ validMessages "ToolChoice" ["validfunction", "validfunction"] }},...
"Error","MATLAB:validators:mustBeTextScalar"));
end

function apiVersions = iGetAPIVersions()
apiVersions = cellstr(llms.azure.apiVersions);
end