-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move model capabilitiy verification out of openAIChat.m, for maintain… #37
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 59.81% 55.73% -4.09%
==========================================
Files 30 33 +3
Lines 1854 2015 +161
==========================================
+ Hits 1109 1123 +14
- Misses 745 892 +147 ☔ View full report in Codecov by Sentry. |
That's codecov missing coverage during test class creation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's looking great, thanks for doing this Christopher.
"gpt-3.5-turbo","gpt-3.5-turbo-0125", ... | ||
"gpt-3.5-turbo-1106",... | ||
])} = "gpt-3.5-turbo" | ||
nvp.ModelName (1,1) string {mustBeModel} = "gpt-3.5-turbo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still get tab completion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to create a json file for tab completion. That should then also enable completion for other NVPs.
Move model capability verification out of main openAIChat class, for maintainability
Also, fix that
bot=openAIChat(ResponseFormat="json")
did not setbot.ResponseFormat
.