Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move model capabilitiy verification out of openAIChat.m, for maintain… #37

Merged
merged 2 commits into from
May 21, 2024

Conversation

ccreutzi
Copy link
Member

@ccreutzi ccreutzi commented May 17, 2024

Move model capability verification out of main openAIChat class, for maintainability

Also, fix that bot=openAIChat(ResponseFormat="json") did not set bot.ResponseFormat.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 17.41573% with 147 lines in your changes are missing coverage. Please review.

Project coverage is 55.73%. Comparing base (f4f97b9) to head (6d34b1f).

Files Patch % Lines
tests/topenAIChat.m 5.76% 147 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   59.81%   55.73%   -4.09%     
==========================================
  Files          30       33       +3     
  Lines        1854     2015     +161     
==========================================
+ Hits         1109     1123      +14     
- Misses        745      892     +147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ccreutzi
Copy link
Member Author

Codecov Report

Attention: Patch coverage is 17.41573% with 147 lines in your changes are missing coverage.

That's codecov missing coverage during test class creation.

Copy link
Member

@vpapanasta vpapanasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's looking great, thanks for doing this Christopher.

"gpt-3.5-turbo","gpt-3.5-turbo-0125", ...
"gpt-3.5-turbo-1106",...
])} = "gpt-3.5-turbo"
nvp.ModelName (1,1) string {mustBeModel} = "gpt-3.5-turbo"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still get tab completion?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to create a json file for tab completion. That should then also enable completion for other NVPs.

@ccreutzi ccreutzi merged commit 1365049 into main May 21, 2024
1 check passed
@ccreutzi ccreutzi deleted the refactor-models branch May 21, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants