Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

little bit of code reformatting #36

Merged
merged 1 commit into from
May 17, 2024
Merged

little bit of code reformatting #36

merged 1 commit into from
May 17, 2024

Conversation

ccreutzi
Copy link
Member

  • Removed a few extra parentheses on if conditions
  • Replaced custom setters with property validations – after verifying that just removing the custom setters does trigger test failures
  • Reformatted acceptable model names so that the lines are logical groups – should make future diffs a tiny bit easier to read

@ccreutzi ccreutzi self-assigned this May 16, 2024
@@ -147,7 +149,7 @@

if ~isempty(systemPrompt)
systemPrompt = string(systemPrompt);
if ~(strlength(systemPrompt)==0)
if systemPrompt ~= ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or if ~isempty(systemPrompt )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeps being tempting, but it's not the same thing. Strings are “proper” matrices, and a scalar can't be empty.

>> isempty("")

ans =

  logical

   0

@ccreutzi ccreutzi removed the request for review from toshiakit May 17, 2024 11:39
@ccreutzi ccreutzi merged commit f4f97b9 into main May 17, 2024
1 check passed
@ccreutzi ccreutzi deleted the refactor-2024-05-16 branch May 17, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants