Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example tests #34

Merged
merged 7 commits into from
May 15, 2024
Merged

Add example tests #34

merged 7 commits into from
May 15, 2024

Conversation

vpapanasta
Copy link
Member

Hi folks,

I am adding some smoke-level tests for most of our examples. For the examples, I did not add a test, we may need to do some small edits. So I decided to wait.

The set-up method creates an .env file which deletes in a teardown. The .env file will contain the secret key. We also have a teardown to make sure the key environment variable is unset and another one to close any opened figures.

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.97%. Comparing base (2eb2199) to head (7dfc0a5).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #34       +/-   ##
===========================================
+ Coverage   44.78%   60.97%   +16.19%     
===========================================
  Files          29       30        +1     
  Lines        1842     1858       +16     
===========================================
+ Hits          825     1133      +308     
+ Misses       1017      725      -292     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ccreutzi ccreutzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't started looking into you mlx changes yet, GitHub does not help there.

tests/texampleTests.m Outdated Show resolved Hide resolved
tests/texampleTests.m Outdated Show resolved Hide resolved
tests/texampleTests.m Show resolved Hide resolved
@vpapanasta vpapanasta requested a review from ccreutzi May 15, 2024 09:24
Revert any change so it matches the version in main
Copy link
Member

@ccreutzi ccreutzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked mlx differences in MATLAB.

@vpapanasta vpapanasta assigned vpapanasta and unassigned debymf and ccreutzi May 15, 2024
@vpapanasta vpapanasta requested a review from debymf May 15, 2024 10:34
@vpapanasta vpapanasta merged commit 9054461 into main May 15, 2024
1 check passed
@vpapanasta vpapanasta deleted the add_example_tests branch May 15, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants