Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to support gpt-4o #33

Merged
merged 7 commits into from
May 15, 2024
Merged

Updated to support gpt-4o #33

merged 7 commits into from
May 15, 2024

Conversation

toshiakit
Copy link
Collaborator

I updated README
openAIChat
and one example that contained a bug.
All examples were tested and ran without errors.

@toshiakit toshiakit requested a review from debymf May 14, 2024 12:18
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.90%. Comparing base (2eb2199) to head (92ebb46).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   44.78%   44.90%   +0.11%     
==========================================
  Files          29       29              
  Lines        1842     1846       +4     
==========================================
+ Hits          825      829       +4     
  Misses       1017     1017              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ccreutzi ccreutzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not reviewed the mlx file change.

README.md Outdated Show resolved Hide resolved
openAIChat.m Show resolved Hide resolved
Copy link
Member

@vpapanasta vpapanasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to add a unit test for the new model in topenAIChat using a secret key. See as example the test point "createOpenAIChatWithOpenAIKey"

README.md Outdated Show resolved Hide resolved
@toshiakit
Copy link
Collaborator Author

It would be great to add a unit test for the new model in topenAIChat using a secret key. See as example the test point "createOpenAIChatWithOpenAIKey"

Done

@toshiakit
Copy link
Collaborator Author

I have not reviewed the mlx file change.

There was an error when I tested the example. The variable name was renamed to "documents" except in one place and that caused the error.

Copy link
Member

@ccreutzi ccreutzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tests/topenAIChat.m Outdated Show resolved Hide resolved
Copy link
Member

@vpapanasta vpapanasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Toshi, I left some extra feedback.

Copy link
Member

@vpapanasta vpapanasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes Toshi.

@toshiakit toshiakit merged commit dbd8b70 into main May 15, 2024
1 check passed
@toshiakit toshiakit deleted the dev-update-0513models branch May 15, 2024 12:57
@debymf debymf mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants