-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to support gpt-4o #33
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 44.78% 44.90% +0.11%
==========================================
Files 29 29
Lines 1842 1846 +4
==========================================
+ Hits 825 829 +4
Misses 1017 1017 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not reviewed the mlx file change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to add a unit test for the new model in topenAIChat using a secret key. See as example the test point "createOpenAIChatWithOpenAIKey"
Co-authored-by: Christopher Creutzig <[email protected]>
…p-learning/llms-with-matlab into dev-update-0513models
Done |
There was an error when I tested the example. The variable name was renamed to "documents" except in one place and that caused the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Toshi, I left some extra feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes Toshi.
…ith-matlab into dev-update-0513models
I updated README
openAIChat
and one example that contained a bug.
All examples were tested and ran without errors.