Reflecting the updated models released on April 9, 2024 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9fe8a06.
ccreutzi
reviewed
Apr 15, 2024
ccreutzi
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
I'm fine with the code changes and just assume that you (and maybe one of the other reviewers) know enough about the currently offered models to assess which model/parameter combinations make sense to support.
Too bad GitHub doesn't show a diff of the mlx file.
vpapanasta
reviewed
Apr 15, 2024
vpapanasta
reviewed
Apr 15, 2024
vpapanasta
reviewed
Apr 15, 2024
vpapanasta
requested changes
Apr 15, 2024
vpapanasta
approved these changes
Apr 16, 2024
| @@ -49,8 +49,10 @@ | |||
| catalog("llms:mustBeMessagesOrTxt") = "Messages must be text with one or more characters or an openAIMessages objects."; | |||
There was a problem hiding this comment.
Messages must be nonempty char, string, or openAIMessages object.
| image_path = "peppers.png"; | ||
| messages = openAIMessages; | ||
| messages = addUserMessageWithImages(messages,"What is in the image?",image_path); | ||
| [txt,response] = generate(chat,messages); | ||
| [txt,response] = generate(chat,messages,MaxNumTokens=4096); | ||
| % Should output the description of the image |
There was a problem hiding this comment.
Returns image description
There was a problem hiding this comment.
"in" should be upper case, i.e. AnalyzeSentimentInTextUsingChatGPTInJSONMode.mlx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of supported models updates to reflect the changes in released on April 9, 2024.