Merge pull request #71 from matlab-deep-learning/avoid-content-error

Avoid bogus access to `json.choices.delta.content`
matlab-deep-learning · Aug 5, 2024 · fce8bb8 · fce8bb8
2 parents 062538c + 53c1df5
commit fce8bb8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/+llms/+stream/responseStreamer.m b/+llms/+stream/responseStreamer.m
@@ -84,7 +84,8 @@
                                 end
                                 this.StreamFun('');
                                 this.ResponseText = txt;
-                            else
+                            elseif isfield(json.choices,"delta") && ...
+                                    isfield(json.choices.delta,"content")
                                 txt = json.choices.delta.content;
                                 this.StreamFun(txt);
                                 this.ResponseText = [this.ResponseText txt];

diff --git a/tests/topenAIChat.m b/tests/topenAIChat.m
@@ -97,6 +97,14 @@ function invalidInputsConstructor(testCase, InvalidConstructorInput)
             testCase.verifyError(@()openAIChat(InvalidConstructorInput.Input{:}), InvalidConstructorInput.Error);
         end
 
+        function generateWithStreamFunAndMaxNumTokens(testCase)
+            sf = @(x) fprintf("%s",x);
+            chat = openAIChat(StreamFun=sf);
+            result = generate(chat,"Why is a raven like a writing desk?",MaxNumTokens=5);
+            testCase.verifyClass(result,"string");
+            testCase.verifyLessThan(strlength(result), 100);
+        end
+
         function generateWithToolsAndStreamFunc(testCase)
             import matlab.unittest.constraints.HasField