Merge pull request #9 from matlab-deep-learning/dev-update-gpt-4-visi…

…on-preview Dev update gpt 4 vision preview
matlab-deep-learning · Feb 13, 2024 · ab154ef · ab154ef
2 parents a038630 + 845c874
commit ab154ef
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 8 deletions.
diff --git a/+llms/+internal/callOpenAIChatAPI.m b/+llms/+internal/callOpenAIChatAPI.m
@@ -131,7 +131,7 @@
 
 nvpOptions = keys(dict);
 if strcmp(nvp.ModelName,'gpt-4-vision-preview')
-    nvpOptions(ismember(nvpOptions,["MaxNumTokens","StopSequences"])) = [];
+    nvpOptions(ismember(nvpOptions,"StopSequences")) = [];
 end
 
 for opt = nvpOptions.'

diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
 *.env
 *.asv
+*.mat
 startup.m
diff --git a/examples/ExampleEmbeddings.mlx b/examples/ExampleEmbeddings.mlx
diff --git a/examples/ExampleGPT4Vision.mlx b/examples/ExampleGPT4Vision.mlx
diff --git a/openAIChat.m b/openAIChat.m
@@ -209,8 +209,8 @@
             %                          reproducible responses
             %                           
             % Currently, GPT-4 Turbo with vision does not support the message.name 
-            % parameter, functions/tools, response_format parameter, stop
-            % sequences, and max_tokens
+            % parameter, functions/tools, response_format parameter, and stop
+            % sequences. It also has a low MaxNumTokens default, which can be overridden.
 
             arguments
                 this                    (1,1) openAIChat
@@ -221,11 +221,6 @@
                 nvp.Seed                {mustBeIntegerOrEmpty(nvp.Seed)} = []
             end
 
-            if nvp.MaxNumTokens ~= Inf && strcmp(this.ModelName,'gpt-4-vision-preview')
-                error("llms:invalidOptionForModel", ...
-                        llms.utils.errorMessageCatalog.getMessage("llms:invalidOptionForModel", "MaxNumTokens", this.ModelName));
-            end
-
             toolChoice = convertToolChoice(this, nvp.ToolChoice);
             if ~isempty(nvp.ToolChoice) && strcmp(this.ModelName,'gpt-4-vision-preview')
                 error("llms:invalidOptionForModel", ...