-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update brew scripts and configs #871
Open
jeffbyrnes
wants to merge
7
commits into
mathiasbynens:main
Choose a base branch
from
jeffbyrnes:update-brew-scripts-and-configs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update brew scripts and configs #871
jeffbyrnes
wants to merge
7
commits into
mathiasbynens:main
from
jeffbyrnes:update-brew-scripts-and-configs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Okeanos
added a commit
to Okeanos/dotfiles
that referenced
this pull request
May 19, 2019
jeffbyrnes
force-pushed
the
update-brew-scripts-and-configs
branch
from
July 23, 2019 04:39
13b84b4
to
bf7e287
Compare
addianto
added a commit
to addianto/dotfiles
that referenced
this pull request
Aug 20, 2019
This commit improves the brew formulaes provisioning script by checking existence of `brew` command before execution and also by adding informational messages after installing GNU utilities. The messages follow the content found in the following Pull Request on GitHub: mathiasbynens/dotfiles#871
mathiasbynens
approved these changes
Aug 23, 2019
jeffbyrnes
force-pushed
the
update-brew-scripts-and-configs
branch
from
August 25, 2019 16:02
bf7e287
to
8321a9f
Compare
Rebased against the latest master for a clean merge. |
jeffbyrnes
force-pushed
the
update-brew-scripts-and-configs
branch
from
October 15, 2019 17:02
8321a9f
to
f56c8bc
Compare
Rebased against latest master for a clean merge. |
jeffbyrnes
force-pushed
the
update-brew-scripts-and-configs
branch
from
May 3, 2020 22:21
f56c8bc
to
1c32d55
Compare
Rebased again to maintain a clean merge. |
As such, no need to run it separately. Per Homebrew/brew#50. This was released way back in Homebrew v1.0.0: https://brew.sh/2016/09/21/homebrew-1.0.0/
This raises the visibility of this, ensuring someone who runs this script without reading it (lets face it, that’s a lot of us) is more strongly encouraged to add to their $PATH.
Let operators know how they can make these the defaults.
Per Homebrew/homebrew-core@068955e8cd, the --with-default-names option has been removed from the gnu-sed package. This change: * Drops the argument, so the install works * Echos how to add the necessary path to $PATH in order to replicate the previous behavior (i.e., that gnu-sed is available as sed) Fixes mathiasbynens#869
This option was removed back in Homebrew/homebrew-core#9873. As of wget 1.19, support for IDNs is possible via libidn2. Thankfully, the wget formula requires libidn2 as of Homebrew/homebrew-core#21821 As such, even though the option is dropped, the installation of wget has the same functionality that the option once provided.
This option was removed in Homebrew/homebrew-core@ae89314d37 Thankfully, it was also made the default behavior, so no loss of functionality occurs with a new installation. Fixes mathiasbynens#870
Removed in Homebrew/homebrew-core#34421 Of note: this drops Python 2 support.
jeffbyrnes
force-pushed
the
update-brew-scripts-and-configs
branch
from
December 19, 2020 16:05
1c32d55
to
3dcde32
Compare
I’ve:
@mathiasbynens this should fix up the |
@mathiasbynens going through some older PRs, and thought I’d give this one a bump. Looks like it’ll still merge cleanly, even if it’s long in the tooth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates a variety of things related to Homebrew:
brew cleanup
&brew update
$PATH
forcoreutils
,moreutils
, andfindutils
gnu-sed
(for the others, their defaults are now the same as what the args provided)