Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist visibility of table inspector sections #3997

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

seancolsen
Copy link
Contributor

@seancolsen seancolsen commented Oct 30, 2024

Fixes #2379

This PR makes it so that the toggled visibility of the table inspector and most sections inside it are persisted in localStorage. If you hide the table inspector, it will remain hidden until you open it again — even after you close your browser tab. The same is true for all the sections in the "Table" and "Column" tab. Since there's only one section in the "Record" tab, I didn't bother persisting that, but we could add that later by following the same patterns here.

I opened this PR now because I was doing a lot of work in the table inspector for the record summary stuff, and this actually just made my development process easier. I think it will benefit users too.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Store toggled state in localStorage
@seancolsen seancolsen added this to the v0.2.0 (beta release) milestone Oct 30, 2024
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Oct 30, 2024
@seancolsen seancolsen marked this pull request as ready for review October 30, 2024 18:51
@seancolsen
Copy link
Contributor Author

seancolsen commented Oct 30, 2024

@pavish I've assigned you to review from a code/implementation perspective.

@ghislaineguerin I've assigned you to review from a UX/product perspective to make sure that this is something we want.

Base automatically changed from record_summary_db_fixes to develop October 31, 2024 07:23
Copy link
Contributor

@ghislaineguerin ghislaineguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed UX makes sense. We should store the user's visibility preferences.

Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pavish pavish added this pull request to the merge queue Nov 12, 2024
Merged via the queue into develop with commit fd4090a Nov 12, 2024
45 checks passed
@pavish pavish deleted the persist_inspector_section_visibility branch November 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist visibility of table inspector and its sections within localStorage
3 participants