Fixed formatting strings for timestampsWithTZ #3325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2966
Technical details
In
parse
of DateTimeFormatter the value is calculated by providinguserInputOrServerResponse
andformattingOptions
.We are getting formatting options like so
Now in the
getCanonicalFormattingStrings()
which can be found here, the formatting strings for TZ timestamps are made using thismathesar/mathesar_ui/src/utils/date-time/DateTimeSpecification.ts
Lines 171 to 175 in 704c125
This code returns these values for
timestampWithTZ
andtimestampWithTZFull
Hence
dayjs
was not able to parse datetimestring containing TZ timestamp.Adding a simple
T
fixes the issue.@seancolsen can you please review this.
Screenshots
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin