-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle failed API requests on schema page #3323
Handle failed API requests on schema page #3323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikhilhenry Thanks for the PR! I have a few comments which need to be addressed before merging this in.
Additionally, I notice that this PR does not satisfy the linting rules. Please fix them before marking it as ready for review again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikhilhenry I'm still seeing some linting errors, and a number of test changes that seem to have made into this PR. Please fix them and double check before requesting review.
@pavish I've reverted the changes to the backend and changes to stores/tables.ts and stores/queries.ts using git revert. Could you please let me know if this is the appropriate method to revert these changes or if it would be better for me to open a new PR? Once again, really sorry for the confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikhilhenry Looks good to me! Thanks for your work on this.
093a21e
Fixes #2644
Adds UI elements to display API request errors when fetching tables and queries (explorations) on the schema page in accordance with the provided design reference.
Technical details
Screenshots
Note: This PR is heavily inspired by PR #2829. Thanks to authors for their work!
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin