Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separating filters #1324

Merged
merged 7 commits into from
Oct 2, 2024
Merged

separating filters #1324

merged 7 commits into from
Oct 2, 2024

Conversation

zstone1
Copy link
Contributor

@zstone1 zstone1 commented Sep 23, 2024

Continuing with #1167, this puts all the stuff about filters into a separate file in classical. It ends up being around 1500, which is a very comfortable file size compared to the 7000+ from topology.v. I moved the docs around, hopefully I didn't miss anything.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@zstone1 zstone1 added the "bug" 🐛 This issue (resp. PR) describes (resp. fixes) a "bug" label Sep 25, 2024
@affeldt-aist
Copy link
Member

Maybe for the chaneglog the following is enough (I didn't commit because it calls for a rebase):

# Changed:

- `theories/topology.v` split into `classical/filter.v` and `theories/topology.v`

- moved from `topology.v` to `mathcomp_extra.v`:
  + lemma `and_prop_in`

- moved from `topology.v` to `set_interval.v`:
  + lemmas `bigmax_geP`, `bigmax_gtP`, `bigmin_leP`, `bigmin_ltP`
  + lemmas `mem_inc_segment`, `mem_inc_segment`

@zstone1
Copy link
Contributor Author

zstone1 commented Oct 1, 2024

rebased and changelog updated

@affeldt-aist
Copy link
Member

Start looking good to me: splitting also contributed to make the doc shorter and more readable (no need for toc anymore), we spotted deadcode and potentially improved the naming of a few identifiers (granted these are micro improvements---you may want to double-check them though).

@affeldt-aist affeldt-aist self-requested a review October 2, 2024 02:06
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it is ok. I made a last commit moving a few lemmas further down the hierarchy of files (in particular, bigmin/max lemmas looked a bit out of place in set_interval.v). However, I see that the PR has been marked as "bug" and @proux01 tagged. Is it because of the failing CI? (It has been red for some time but apparently because of third-party packages.)

@zstone1
Copy link
Contributor Author

zstone1 commented Oct 2, 2024

Yeah, I guess I wanted to be sure that I hadn't broken anything by moving stuff across packages. But you're right the build failures are the expected ones. Thanks for picking through this. It's a bit grueling, but you definitely improved things.

@zstone1 zstone1 removed the request for review from proux01 October 2, 2024 02:16
zstone1 and others added 7 commits October 1, 2024 22:18
- duplicated Reserved Notations
- duplicates in doc
- doc formatting
- remove unused notation
- update changelog
- get rid of duplicate identifiers (ending with an apostrophe)
@zstone1 zstone1 merged commit bab1cb0 into math-comp:master Oct 2, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
"bug" 🐛 This issue (resp. PR) describes (resp. fixes) a "bug"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants