-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separating filters #1324
separating filters #1324
Conversation
Maybe for the chaneglog the following is enough (I didn't commit because it calls for a rebase):
|
b808f3b
to
9dad92d
Compare
rebased and changelog updated |
Start looking good to me: splitting also contributed to make the doc shorter and more readable (no need for toc anymore), we spotted deadcode and potentially improved the naming of a few identifiers (granted these are micro improvements---you may want to double-check them though). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, it is ok. I made a last commit moving a few lemmas further down the hierarchy of files (in particular, bigmin/max lemmas looked a bit out of place in set_interval.v
). However, I see that the PR has been marked as "bug" and @proux01 tagged. Is it because of the failing CI? (It has been red for some time but apparently because of third-party packages.)
Yeah, I guess I wanted to be sure that I hadn't broken anything by moving stuff across packages. But you're right the build failures are the expected ones. Thanks for picking through this. It's a bit grueling, but you definitely improved things. |
- remove unused notation - update changelog - get rid of duplicate identifiers (ending with an apostrophe)
299f2b8
to
829fb0b
Compare
Continuing with #1167, this puts all the stuff about filters into a separate file in classical. It ends up being around 1500, which is a very comfortable file size compared to the 7000+ from topology.v. I moved the docs around, hopefully I didn't miss anything.
Checklist
CHANGELOG_UNRELEASED.md
Reference: How to document
Reminder to reviewers