Set onStopConsuming while building consumer and make MessageConsumer accessible to handler functions
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusjunges
changed the title
onStopConsuming call to consumer builder and give instance of MessageConsumer to handler functionsonStopConsuming while building consumer and make MessageConsumer accessible to handler functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the call to set a
onStopConsumingcallback to the Consumer Builder instance instead of the consumer. Previously, you had to create the consumer callingbuildbefore setting theonStopConsumingcallback. This PR makes it possible to set it while building your consumer.Also, an instance of
MessageConsumeris now passed to your handler functions, so it's easier to stop consuming messages.