Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matgl depends on torch==2.2.1 #273

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

Badasper
Copy link
Contributor

Summary

matgl depends on torch==2.2.1 in requirements.txt

Copy link
Contributor

coderabbitai bot commented Jun 21, 2024

Walkthrough

The change involves updating the pip install command within the README.md file to specify a new version (2.2.1) of the torch library. This adjustment ensures users install the correct version of the library.

Changes

File Change Summary
README.md Updated the pip install command to change the torch version to 2.2.1.

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between eacafa3 and 9c5e724.

Files selected for processing (1)
  • README.md (1 hunks)
Additional context used
LanguageTool
README.md

[style] ~17-~17: Style-wise, it’s not ideal to insert an adverb (‘consistently’) in the middle of an infinitive construction (‘to deliver’). Try moving the adverb to avoid split infinitives. (SPLIT_INFINITIVE)
Context: ...s. Graph deep learning models have been shown to consistently deliver exceptional performance as surrogate models for the prediction ...


[locale-violation] ~42-~42: The phrase ‘in future’ is British English. Did you mean: “in the future”? (IN_FUTURE)
Context: ...atGL team as well as other contributors in future. <div style="float: left; padding: 10p...


[style] ~63-~63: The phrase ‘in many cases’ is used quite frequently. Consider using a less frequent alternative to set your writing apart. (IN_MANY_STYLE_CASES)
Context: ...els for property predictions, achieving in many cases accuracies that are better or similar t...


[style] ~188-~188: As an alternative to the over-used intensifier ‘extremely’, consider replacing this phrase. (EN_WEAK_ADJECTIVE)
Context: ...e training, validation and test sets is extremely important to be consistent with the unit used in ...


[uncategorized] ~191-~191: The grammatical number of this noun doesn’t look right. Consider replacing it. (AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)
Context: ...ith unit eV/Å, where n is the number of atom in each structure. n does not need to b...

Markdownlint
README.md

186-186: Expected: 1; Actual: 0; Above (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


218-218: null (MD028, no-blanks-blockquote)
Blank line inside blockquote


223-223: null (MD028, no-blanks-blockquote)
Blank line inside blockquote


185-185: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines


280-280: Unused link or image reference definition: "m3gnetrepo" (MD053, link-image-reference-definitions)
Link and image reference definitions should be needed


281-281: Unused link or image reference definition: "megnetrepo" (MD053, link-image-reference-definitions)
Link and image reference definitions should be needed


291-291: Unused link or image reference definition: "doc" (MD053, link-image-reference-definitions)
Link and image reference definitions should be needed

Additional comments not posted (1)
README.md (1)

113-113: Update to PyTorch Installation Command

The installation command for PyTorch has been updated to specify version 2.2.1 along with compatible versions of torchvision and torchaudio. This change aligns with the latest dependency requirements for the matgl package. Ensure that this version of PyTorch is compatible with other dependencies and the overall environment where matgl is intended to be used.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shyuep shyuep merged commit 82f359a into materialsvirtuallab:main Jun 21, 2024
2 checks passed
@shyuep
Copy link
Contributor

shyuep commented Jun 21, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants