Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce using dgl==1.1.3 in requirement-ci.txt #21

Merged
merged 6 commits into from
Mar 16, 2024

Conversation

kenko911
Copy link
Collaborator

@kenko911 kenko911 commented Mar 13, 2024

Enforce using dgl==1.1.3 in requirement-ci.txt

I have gone through the problem of pydantic, which comes from the graphbolt developed in dgl.2.0.0 or later version. graphbolt is a dataloading framework for GNN that provides well-defined APIs for each stage of the data pipeline and multiple standard implementations. I am not sure if we could just simply remove it from dgl package. At the moment, I think we can enforce using dgl.1.1.3 instead so that all united tests work. However, I don't understand why ruff crashes.

@kenko911 kenko911 closed this Mar 13, 2024
@kenko911 kenko911 changed the title update matgl version in requirement-ci.txt Enforce using dgl==1.1.3 in requirement-ci.txt Mar 15, 2024
@kenko911 kenko911 reopened this Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (85738fd) to head (69a34a7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          270       271    +1     
=========================================
+ Hits           270       271    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kenko911
Copy link
Collaborator Author

Hi @janosh, I have gone through the problem of pydantic, which comes from the graphbolt developed in dgl.2.0.0 or later version. graphbolt is a dataloading framework for GNN that provides well-defined APIs for each stage of the data pipeline and multiple standard implementations. I am not sure if we could just simply remove it from dgl package. At the moment, I think we can enforce using dgl.1.1.3 instead so that all united tests work. However, I don't understand why ruff crashes.

@kenko911 kenko911 requested a review from janosh March 15, 2024 18:59
@janosh
Copy link
Collaborator

janosh commented Mar 15, 2024

I am not sure if we could just simply remove it from dgl package

does that mean matgl is not using graphbolt anyway?

@janosh janosh added dependencies Pull requests that update a dependency file matgl Graph deep learning library for materials labels Mar 15, 2024
@kenko911
Copy link
Collaborator Author

kenko911 commented Mar 15, 2024

@janosh, yes. We are not using it at the moment. I need to have a closer look at this new package. I am not sure if it improves our dataloader.

@kenko911 kenko911 merged commit 11a563a into materialsvirtuallab:main Mar 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file matgl Graph deep learning library for materials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants