-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce using dgl==1.1.3 in requirement-ci.txt #21
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 270 271 +1
=========================================
+ Hits 270 271 +1 ☔ View full report in Codecov by Sentry. |
Hi @janosh, I have gone through the problem of pydantic, which comes from the graphbolt developed in dgl.2.0.0 or later version. graphbolt is a dataloading framework for GNN that provides well-defined APIs for each stage of the data pipeline and multiple standard implementations. I am not sure if we could just simply remove it from dgl package. At the moment, I think we can enforce using dgl.1.1.3 instead so that all united tests work. However, I don't understand why ruff crashes. |
does that mean |
@janosh, yes. We are not using it at the moment. I need to have a closer look at this new package. I am not sure if it improves our dataloader. |
Enforce using
dgl==1.1.3
inrequirement-ci.txt
I have gone through the problem of pydantic, which comes from the graphbolt developed in dgl.2.0.0 or later version. graphbolt is a dataloading framework for GNN that provides well-defined APIs for each stage of the data pipeline and multiple standard implementations. I am not sure if we could just simply remove it from dgl package. At the moment, I think we can enforce using dgl.1.1.3 instead so that all united tests work. However, I don't understand why ruff crashes.