-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP2K fixes #1056
Merged
Merged
CP2K fixes #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plus typo fix
…no optional files will be written before there was no way to disable writing potentially redundant BASIS and POTENTIAL files
…s None KPOINTS are not compatible with orbital transformation (OT) mode and CP2K will crash if found
This all looks good to me. |
failing tests will be fixed by next |
Hi @janosh, best to wait for next release to avoid any indeterministic behaviour from the CI. |
raised TypeError: 'NoneType' object is not subscriptable
seems to be a bug in CP2K that it doesn't include E prefix for exponents with 3 digits update test_structure_optimization to expect correct stress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes several issues with running CP2K in orbital transformation (OT) mode which crashes if it finds a
KPOINTS
file which the currentCp2kInputGenerator
does not allow to disable.it also fixes
parsing the
stress_tensor
inwhich was previously looking for
stress
incp2k.out
(which i did not see mentioned in CP2K docs). it now looks forstress_tensor
(still usingstress
as fallback in case i missed something)ignoring empty
BASIS
andPOTENTIAL
files in"cp2k_run_dir"
which previously causedInvalid Element = None
inatomate2/src/atomate2/cp2k/schemas/calculation.py
Line 473 in 0a0d47c
it goes hand in hand with materialsproject/pymatgen#4169 that fixes a number of bugs in
pymatgen
CP2K modulespinging @chiang-yuan and @utf