Feature/typos 1

[sydhds]

• document all added functions
• try in sandbox /simulation/labnet
  • if part of node-launch, checked using the resync_check flag
• unit tests on the added/changed features
  • make tests compile
  • make tests pass
• add logs allowing easy debugging in case the changes caused problems
• if the API has changed, update the API specification

[sydhds]

One remaining error reported by typos:

Some(grpc_model::operation_type::Type::ExecutSc(execute_sc));

Fixing the typo on grpc enum Type name should not break compatibility right? @Leo-Besancon @bilboquet

[Leo-Besancon]

One remaining error reported by typos:

Some(grpc_model::operation_type::Type::ExecutSc(execute_sc));

Fixing the typo on grpc enum Type name should not break compatibility right? @Leo-Besancon @bilboquet

I think we have to be careful about:

• Request params from the JSON-RPC API
• Maybe response params (but less important)
• For GRPC, I think it's ok if done in a certain way (for example, the order of the elements do not change), but maybe @bilboquet or @modship can confirm

I don't see other cases that raise issues

[modship]

One remaining error reported by typos:

Some(grpc_model::operation_type::Type::ExecutSc(execute_sc));

Fixing the typo on grpc enum Type name should not break compatibility right? @Leo-Besancon @bilboquet

I think we have to be careful about:

• Request params from the JSON-RPC API
• Maybe response params (but less important)
• For GRPC, I think it's ok if done in a certain way (for example, the order of the elements do not change), but maybe @bilboquet or @modship can confirm

I don't see other cases that raise issues

enum name type come from massa-proto so we should update it if we modify

[sydhds]

One remaining error reported by typos:

Some(grpc_model::operation_type::Type::ExecutSc(execute_sc));

Fixing the typo on grpc enum Type name should not break compatibility right? @Leo-Besancon @bilboquet

Try to serialize with the old name versus the new name and it does not change :)

Waiting for massalabs/massa-proto#67 to be merged

[sydhds]

One remaining error reported by typos:

Some(grpc_model::operation_type::Type::ExecutSc(execute_sc));

Fixing the typo on grpc enum Type name should not break compatibility right? @Leo-Besancon @bilboquet

Try to serialize with the old name versus the new name and it does not change :)

Waiting for massalabs/massa-proto#67 to be merged

The CI of massa-proto reports a breaking change and it's kinda difficult to see the impact in the tooling. Maybe drop this and keep it that way? @Leo-Besancon @bilboquet

[Leo-Besancon]

One remaining error reported by typos:

Some(grpc_model::operation_type::Type::ExecutSc(execute_sc));

Fixing the typo on grpc enum Type name should not break compatibility right? @Leo-Besancon @bilboquet

Try to serialize with the old name versus the new name and it does not change :)
Waiting for massalabs/massa-proto#67 to be merged

The CI of massa-proto reports a breaking change and it's kinda difficult to see the impact in the tooling. Maybe drop this and keep it that way? @Leo-Besancon @bilboquet

This would be fine with me.

[bilboquet]

This would be fine with me.

It's fine to me too until we have time to work on an automatic pipeline for such a change

[bilboquet]

it looking good