New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix join error message (was inconsistent with: VM controller thread) #4744

Open

sydhds wants to merge 2 commits into main from feature/exec_manager_join_expect_msg_1

Contributor

sydhds commented Sep 19, 2024

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification


          Fix join error message (was inconsistent with: VM controller thread)

a23b95e

sydhds requested review from bilboquet and Leo-Besancon

September 19, 2024 09:46

Leo-Besancon previously approved these changes

View reviewed changes

Contributor

Leo-Besancon commented Sep 19, 2024

Approved the change, I think just the fmt that isn't happy but otherwise ok!


          Cargo fmt pass

4b98b3c

sydhds dismissed Leo-Besancon’s stale review via

4b98b3c

September 20, 2024 08:47

Leo-Besancon approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet