New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-design asc msg trigger ledger changes #4738

Closed

Leo-Besancon wants to merge 2 commits into mainnet_2_3 from fix_asc_msg_trigger_ledger_changes

Contributor

Leo-Besancon commented Aug 6, 2024

We should be cautious about the cost of this redesign (locks, clones), and if they can be avoided.

document all added functions
try in sandbox /simulation/labnet
- if part of node-launch, checked using the resync_check flag
unit tests on the added/changed features
- make tests compile
- make tests pass
add logs allowing easy debugging in case the changes caused problems
if the API has changed, update the API specification

Leo-Besancon added 2 commits

August 6, 2024 12:08


          Fix with previous value

ce7bba2


          clippy + fmt + small optim

babaf1d

Leo-Besancon force-pushed the fix_asc_msg_trigger_ledger_changes branch from 517cae6 to babaf1d Compare

August 6, 2024 11:26

Contributor Author

Leo-Besancon commented Aug 12, 2024

Closing this PR (that decrease performance) in favor of #4740

Leo-Besancon closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet