Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixe issue with fees #4734

Merged
merged 7 commits into from
Aug 1, 2024
Merged

Fixe issue with fees #4734

merged 7 commits into from
Aug 1, 2024

Conversation

damip
Copy link
Member

@damip damip commented Jul 31, 2024

  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@damip damip requested a review from Leo-Besancon July 31, 2024 11:16
@Leo-Besancon Leo-Besancon changed the base branch from main to mainnet_2_3 July 31, 2024 11:39
@Leo-Besancon Leo-Besancon merged commit 2d6e1ff into mainnet_2_3 Aug 1, 2024
11 checks passed
@sydhds sydhds deleted the debug_fees branch October 9, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

@modship modship Awaiting requested review from modship

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damip @modship @Leo-Besancon