Skip to content

Deferred calls

Deferred calls #134

Triggered via pull request August 16, 2024 15:36
Status Success
Total duration 34s
Artifacts

link-check.yml

on: pull_request
markdown-link-check
26s
markdown-link-check
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 2 warnings
unneeded `return` statement: massa-models/src/deferred_call_id.rs#L231
error: unneeded `return` statement --> massa-models/src/deferred_call_id.rs:231:17 | 231 | / return Err(ModelsError::InvalidVersionError(format!( 232 | | "Invalid version to create an DeferredCallId: {}", 233 | | version 234 | | ))) | |___________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_return)]` help: remove `return` | 231 ~ Err(ModelsError::InvalidVersionError(format!( 232 + "Invalid version to create an DeferredCallId: {}", 233 + version 234 + ))) |
this expression creates a reference which is immediately dereferenced by the compiler: massa-models/src/deferred_call_id.rs#L131
error: this expression creates a reference which is immediately dereferenced by the compiler --> massa-models/src/deferred_call_id.rs:131:40 | 131 | serializer.serialize_bytes(&self.as_bytes()) | ^^^^^^^^^^^^^^^^ help: change this to: `self.as_bytes()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
you should consider adding a `Default` implementation for `DeferredCallIdDeserializer`: massa-models/src/deferred_call_id.rs#L68
error: you should consider adding a `Default` implementation for `DeferredCallIdDeserializer` --> massa-models/src/deferred_call_id.rs:68:5 | 68 | / pub fn new() -> Self { 69 | | Self { 70 | | bytes_deserializer: VecU8Deserializer::new( 71 | | std::ops::Bound::Included(0), ... | 74 | | } 75 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `-D clippy::new-without-default` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::new_without_default)]` help: try adding this | 66 + impl Default for DeferredCallIdDeserializer { 67 + fn default() -> Self { 68 + Self::new() 69 + } 70 + } |
unneeded `return` statement: massa-models/src/deferred_call_id.rs#L231
error: unneeded `return` statement --> massa-models/src/deferred_call_id.rs:231:17 | 231 | / return Err(ModelsError::InvalidVersionError(format!( 232 | | "Invalid version to create an DeferredCallId: {}", 233 | | version 234 | | ))) | |___________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_return)]` help: remove `return` | 231 ~ Err(ModelsError::InvalidVersionError(format!( 232 + "Invalid version to create an DeferredCallId: {}", 233 + version 234 + ))) |
this expression creates a reference which is immediately dereferenced by the compiler: massa-models/src/deferred_call_id.rs#L131
error: this expression creates a reference which is immediately dereferenced by the compiler --> massa-models/src/deferred_call_id.rs:131:40 | 131 | serializer.serialize_bytes(&self.as_bytes()) | ^^^^^^^^^^^^^^^^ help: change this to: `self.as_bytes()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
you should consider adding a `Default` implementation for `DeferredCallIdDeserializer`: massa-models/src/deferred_call_id.rs#L68
error: you should consider adding a `Default` implementation for `DeferredCallIdDeserializer` --> massa-models/src/deferred_call_id.rs:68:5 | 68 | / pub fn new() -> Self { 69 | | Self { 70 | | bytes_deserializer: VecU8Deserializer::new( 71 | | std::ops::Bound::Included(0), ... | 74 | | } 75 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `-D clippy::new-without-default` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::new_without_default)]` help: try adding this | 66 + impl Default for DeferredCallIdDeserializer { 67 + fn default() -> Self { 68 + Self::new() 69 + } 70 + } |
unused macro definition: `DeferredCallIdVariant`: massa-models/src/deferred_call_id.rs#L28
error: unused macro definition: `DeferredCallIdVariant` --> massa-models/src/deferred_call_id.rs:28:12 | 28 | pub struct DeferredCallId(Vec<u8>); | ^^^^^^^^^^^^^^
unused macro definition: `DeferredCallId`: massa-models/src/deferred_call_id.rs#L28
error: unused macro definition: `DeferredCallId` --> massa-models/src/deferred_call_id.rs:28:12 | 28 | pub struct DeferredCallId(Vec<u8>); | ^^^^^^^^^^^^^^ | = note: `-D unused-macros` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_macros)]`
unused macro definition: `DeferredCallIdVariant`: massa-models/src/deferred_call_id.rs#L28
error: unused macro definition: `DeferredCallIdVariant` --> massa-models/src/deferred_call_id.rs:28:12 | 28 | pub struct DeferredCallId(Vec<u8>); | ^^^^^^^^^^^^^^
unused macro definition: `DeferredCallId`: massa-models/src/deferred_call_id.rs#L28
error: unused macro definition: `DeferredCallId` --> massa-models/src/deferred_call_id.rs:28:12 | 28 | pub struct DeferredCallId(Vec<u8>); | ^^^^^^^^^^^^^^ | = note: `-D unused-macros` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_macros)]`
markdown-link-check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
markdown-link-check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/