Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmv1 improvements #293

Merged
merged 81 commits into from
Jul 26, 2023
Merged

wasmv1 improvements #293

merged 81 commits into from
Jul 26, 2023

Conversation

Eitu33
Copy link
Contributor

@Eitu33 Eitu33 commented Jul 26, 2023

No description provided.

Jean-François Morcillo and others added 30 commits June 21, 2023 11:54
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
* Add get_current_period and get_current_thread abis

* Write ABI test

* wasm_add instead of wasm
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
* Added hash abi

* Added keccak256

* Fixed ABI return values
* Added get_current_slot abi

* Sync

* Updated datastore_test

* Cargo fmt

* Target common branch
Make build work on windows (Leo-Besancon)

Signed-off-by: Jean-François Morcillo <[email protected]>
Jean-François Morcillo and others added 8 commits July 20, 2023 09:57
* Update test interface for exhaustive sc

* Moved bs58 to dev dependancy

* Comment on abi_local_call to state we reuse CallRequest, sync wasm

Signed-off-by: Jean-François Morcillo <[email protected]>

* Update test interface for exhaustive sc

* Moved bs58 to dev dependancy

* update wasm for test_exhaustive sc

---------

Signed-off-by: Jean-François Morcillo <[email protected]>
Co-authored-by: Jean-François Morcillo <[email protected]>
@Leo-Besancon Leo-Besancon self-requested a review July 26, 2023 11:55
Leo-Besancon
Leo-Besancon previously approved these changes Jul 26, 2023
Copy link
Contributor

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved despite targeting a proto rs that is not sorted!

@Eitu33
Copy link
Contributor Author

Eitu33 commented Jul 26, 2023

bros merge

@bors
Copy link
Contributor

bors bot commented Jul 26, 2023

👊

@Eitu33
Copy link
Contributor Author

Eitu33 commented Jul 26, 2023

bors merge

bors bot added a commit that referenced this pull request Jul 26, 2023
293: wasmv1 improvements r=Eitu33 a=Eitu33



Co-authored-by: Jean-François Morcillo <[email protected]>
Co-authored-by: Leo-Besancon <[email protected]>
Co-authored-by: Sydhds <[email protected]>
Co-authored-by: Thomas Plisson <[email protected]>
Co-authored-by: Eitu33 <[email protected]>
Co-authored-by: JF <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 26, 2023

Build failed:

@Eitu33
Copy link
Contributor Author

Eitu33 commented Jul 26, 2023

bors merge

bors bot added a commit that referenced this pull request Jul 26, 2023
293: wasmv1 improvements r=Eitu33 a=Eitu33



Co-authored-by: Jean-François Morcillo <[email protected]>
Co-authored-by: Leo-Besancon <[email protected]>
Co-authored-by: Sydhds <[email protected]>
Co-authored-by: Thomas Plisson <[email protected]>
Co-authored-by: Eitu33 <[email protected]>
Co-authored-by: JF <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 26, 2023

Build failed:

@Eitu33
Copy link
Contributor Author

Eitu33 commented Jul 26, 2023

bors merge

bors bot added a commit that referenced this pull request Jul 26, 2023
293: wasmv1 improvements r=Eitu33 a=Eitu33



Co-authored-by: Jean-François Morcillo <[email protected]>
Co-authored-by: Leo-Besancon <[email protected]>
Co-authored-by: Sydhds <[email protected]>
Co-authored-by: Thomas Plisson <[email protected]>
Co-authored-by: Eitu33 <[email protected]>
Co-authored-by: JF <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 26, 2023

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

Response status code: 422
{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@Leo-Besancon Leo-Besancon self-requested a review July 26, 2023 12:38
@Eitu33
Copy link
Contributor Author

Eitu33 commented Jul 26, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 26, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@Eitu33 Eitu33 merged commit ad4f653 into main Jul 26, 2023
13 checks passed
@bors bors bot deleted the feature/Improve_ABI_types_in_wasmv1 branch July 26, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants