repo: pretend root commit exists in the root operation #4594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll add a few helper methods to RepoLoader. It seems also nicer that repo.loader() doesn't allocate new RepoLoader.
It's hosted by RepoLoader for now. I'm not sure if we'll need a higher-level abstraction like Store.
See the next patch for why. It might look odd that OpStore depends on the root CommitId, but that seems okay because OpStore manages Views, and a View is basically a set of CommitIds.
This removes an invalid View state from the root operation. Note that the root index will have to be reindexed in order to resolve "root()" in the root operation. I don't think this would practically matter, so this patch doesn't bump the index version to invalidate the existing indexes. See also 48a9f9e "repo: use Transaction for creating repo-init operation."
It no longer makes sense to handle missing root commit by the revset frontend, but panicking wouldn't be good either. Let's make it error out.
yuja
force-pushed
the
push-tqstvzwvtwny
branch
from
18cbea9
to
e4ffd3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md