Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vault Creation #1121

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Vault Creation #1121

wants to merge 22 commits into from

Conversation

Patricie29
Copy link
Collaborator

@Patricie29 Patricie29 commented Sep 11, 2024 •
edited
Loading

This PR includes:

  • new gradient colors for vaults page
  • hiding credit account selection (working only with wallet)
  • whole page overlay for the first step of a vault creation
  • dynamic input component reused for all the forms inputs
  • second step for the vault creation - which will include the vaults_address in the url
Screenshot 2024-09-11 at 4 41 49 PM Screenshot 2024-09-11 at 4 42 56 PM Screenshot 2024-09-11 at 4 43 21 PM

@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mars-v2-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 9:30am

@Patricie29 Patricie29 marked this pull request as ready for review September 11, 2024 15:07
linkielink
linkielink requested changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@linkielink linkielink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all, solid work so far. I would make sure that you don't introduce unnecessary duplicated or new code, so we can reuse components, that you had to create for these UIs in the future.

src/components/common/Background.tsx Outdated Show resolved Hide resolved
src/components/common/Icons/Safe.svg Outdated Show resolved Hide resolved
src/components/common/Icons/Safe.svg Outdated Show resolved Hide resolved
src/components/common/Icons/Safe.svg Outdated Show resolved Hide resolved
src/components/common/Icons/Safe.svg Outdated Show resolved Hide resolved
src/components/vaults/community/createVault/index.tsx
Comment on lines +142 to +145
<Text size='xs' className='text-white/50'>
Setup your wallet with Stargaze or an IBC/ICNS Domain so that you can populate a
profile image, name and social links.
</Text>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to Stargaze (maybe they have a tutorial) and ICNS (maybe this article: https://medium.com/@icns/announcing-icns-the-interchain-name-service-e61e0c3e2abb)

src/components/vaults/community/createVault/index.tsx Outdated Show resolved Hide resolved
src/components/vaults/community/createVault/index.tsx Outdated Show resolved Hide resolved
src/components/vaults/dummyData.ts Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get the data structure from the SC team already to be prepared for mainnet/testnet data.

tailwind.config.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linkielink linkielink linkielink requested changes

@bobthebuidlr bobthebuidlr Awaiting requested review from bobthebuidlr bobthebuidlr is a code owner

@StefChatz StefChatz Awaiting requested review from StefChatz StefChatz is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Patricie29 @linkielink