Remove deposit "on behalf of" [audit] #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
force-pushed
the
MP-2840-lend-action-can-permanently-fail
branch
from
85dd7e5
to
d685525
Compare
grod220
changed the title
piobab
approved these changes
Jul 4, 2023
thec00n
approved these changes
Jul 5, 2023
piobab
pushed a commit
that referenced
this pull request
Jul 20, 2023
brimigs
pushed a commit
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a new asset is listed, someone can deposit on behalf of Credit Manager. If they do this before any other lends have occurred there, they can cause it to throw errors for subsequent lenders via Credit Manager.
The reason is, Credit Manager is not expecting someone to be able to deposit to Red Bank on behalf of itself. After discussing with Piotr and others, we cannot think of a good reason why this functionality exists.
This PR removes
on_behalf_offield from Red Bank, solving the Credit Manager vulnerability at the same time.Note:: Running fmt/clippy found a few things, hence some unrelated code fixes/formatting.