Manage index settings in Vespa application package #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
force-pushed
the
yihan/update-index-settings
branch
from
1246404
to
4664309
Compare
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
force-pushed
the
yihan/update-index-settings
branch
from
5b444b8
to
88a14f5
Compare
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
changed the title
papa99do
force-pushed
the
yihan/update-index-settings
branch
from
88a14f5
to
3e280ff
Compare
papa99do
commented
Aug 6, 2024
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
commented
Aug 6, 2024
| logger.warn(f"Multiple schemas with name {name} found in services.xml, removing all") | ||
| if should_deploy is None or should_deploy is True: | ||
| prepare_response = self.vespa_client.prepare(prepare_url) | ||
| # TODO handle prepare configChangeActions |
There was a problem hiding this comment.
This configChangeActions field in the response from Vespa contains a list of actions (possibly empty) that must be performed in order to apply some config changes between the current active application and this next prepared application. hese actions are organized into three categories; restart, reindex, and refeed See https://docs.vespa.ai/en/reference/deploy-rest-api-v2.html#prepare-session for an example.
What should we do when this list is not empty?
- For requests modifying schemas (in the future), if we get any action in the list, should we reject the request?
- For bootstrap and rollback (in the future if they use deployment session after the Vespa bugfix), should we allow restart?
@farshidz, what's your thought on this?
papa99do
commented
Aug 7, 2024
| services.xml file only has `node` config and empty `document-api` and `search` elements initially. Please | ||
| note that any manual config change in container section will be overwritten. | ||
| """ | ||
| container_element = self._ensure_only_one('container') |
There was a problem hiding this comment.
Our approach of fresh bootstrapping components config of container is based on following assumptions:
- There's only one container element in the services.xml file.
- All configs in the container element except the nodes section is fully controlled by Marqo.
These assumption might not be true in following cases:
- non-HA to HA migration in Marqo Cloud. A transiting state will have two container elements. In this case, we'd like to fail the bootstrapping process anyways to avoid entering any weird state. Also Marqo Cloud will make sure the upgrade of Marqo is blocked when processing migration
- OS customers could have multiple container clusters defined. (one use case is the separate the index and search traffic). Do we need to support this?
- OS customers could have other configuration in container section. should we keep those?
If we have to support the cases above, I'll need to change the fresh bootstrapping process to an incremental one, which will make the logic more complicated. @farshidz , what's your thought?
papa99do
commented
Aug 7, 2024
| # Migrate existing index settings from previous versions of Marqo | ||
| if not self.is_configured: | ||
| if existing_index_settings is not None and len(existing_index_settings) > 0: | ||
| logger.info(f'Importing existing index settings {[index.json for index in existing_index_settings]}') |
There was a problem hiding this comment.
@farshidz, Do we have any security concerns of logging out the existing index settings?
papa99do
commented
Aug 7, 2024
| self._store.save_file(content, 'validation-overrides.xml') | ||
|
|
||
| def _validate_services_xml_for_rollback(self, services_xml_backup: str) -> None: | ||
| services_xml_old = ServiceXml(services_xml_backup) |
There was a problem hiding this comment.
During the rollback, if we detect the changes in 'content/documents' or any 'nodes' elements in services.xml, we will abort the rollback. This is to avoid rolling back to an inconsistent state. Should we capture any diffs of the services.xml file in the log for debugging purpose? @farshidz
RaynorChavez
reviewed
Aug 7, 2024
| @@ -0,0 +1,4 @@ | |||
| <query-profile id="default"> | |||
| <field name="maxHits">1000</field> | |||
There was a problem hiding this comment.
This is used for testing. I used a different value to test if the bootstrapping process overrides this value
papa99do
force-pushed
the
yihan/update-index-settings
branch
from
3e280ff
to
1867a84
Compare
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
force-pushed
the
yihan/update-index-settings
branch
from
8a4bddb
to
82900d4
Compare
papa99do
force-pushed
the
yihan/update-index-settings
branch
from
4d1b53d
to
abdc84a
Compare
papa99do
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Reliability improvements
What is the current behavior? (You can also link to an open issue here)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, there are no changes to the external APIs or customer-facing behaviour of Marqo
Have unit tests been run against this PR? (Has there also been any additional testing?)
Yes
Related Python client changes (link commit/PR here)
N/A
Related documentation changes (link commit/PR here)
N/A
Other information:
Please check if the PR fulfills these requirements