Skip to content

Commit

Permalink
Remove call_status_override_on_cancellation, peer_state_based_framing…
Browse files Browse the repository at this point in the history
… experiments.

The peer_state_based_framing experiment is not used. The other experiment has been rolled out to 100% in prod for a while now. The expiry date of a few other experiments are updated.

PiperOrigin-RevId: 662565880
  • Loading branch information
Vignesh2208 authored and copybara-github committed Aug 13, 2024
1 parent 39e0f06 commit 4fd48b1
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 105 deletions.
5 changes: 0 additions & 5 deletions bazel/experiments.bzl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

48 changes: 0 additions & 48 deletions src/core/lib/experiments/experiments.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 0 additions & 19 deletions src/core/lib/experiments/experiments.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 5 additions & 20 deletions src/core/lib/experiments/experiments.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,6 @@

# This file only defines the experiments. Refer to rollouts.yaml for the rollout
# state of each experiment.
- name: call_status_override_on_cancellation
description:
Avoid overriding call status of successfully finished calls if it races with
cancellation.
expiry: 2024/08/01
owner: [email protected]
test_tags: []
- name: call_tracer_in_transport
description: Transport directly passes byte counts to CallTracer.
expiry: 2024/09/30
Expand Down Expand Up @@ -82,7 +75,7 @@
uses_polling: true
- name: event_engine_listener
description: Use EventEngine listeners instead of iomgr's grpc_tcp_server
expiry: 2024/10/01
expiry: 2024/12/01
owner: [email protected]
test_tags: ["core_end2end_test", "event_engine_listener_test"]
uses_polling: true
Expand Down Expand Up @@ -110,14 +103,6 @@
expiry: 2024/09/15
owner: [email protected]
test_tags: [flow_control_test]
- name: peer_state_based_framing
description:
If set, the max sizes of frames sent to lower layers is controlled based
on the peer's memory pressure which is reflected in its max http2 frame
size.
expiry: 2024/08/01
owner: [email protected]
test_tags: ["flow_control_test"]
- name: pick_first_new
description: New pick_first impl with memory reduction.
expiry: 2024/07/30
Expand All @@ -132,7 +117,7 @@
allow_in_fuzzing_config: false # experiment currently crashes if enabled
- name: schedule_cancellation_over_write
description: Allow cancellation op to be scheduled over a write
expiry: 2024/08/01
expiry: 2024/12/01
owner: [email protected]
test_tags: []
- name: server_privacy
Expand All @@ -148,17 +133,17 @@
TCP would not indicate completion of a read operation until a specified
number of bytes have been read over the socket.
Buffers are also allocated according to estimated RPC sizes.
expiry: 2024/08/01
expiry: 2024/12/01
owner: [email protected]
test_tags: ["endpoint_test", "flow_control_test"]
- name: tcp_rcv_lowat
description: Use SO_RCVLOWAT to avoid wakeups on the read path.
expiry: 2024/08/01
expiry: 2024/12/01
owner: [email protected]
test_tags: ["endpoint_test", "flow_control_test"]
- name: trace_record_callops
description: Enables tracing of call batch initiation and completion.
expiry: 2024/08/01
expiry: 2024/12/01
owner: [email protected]
test_tags: []
- name: unconstrained_max_quota_buffer_size
Expand Down
4 changes: 0 additions & 4 deletions src/core/lib/experiments/rollouts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@
#
# Supported platforms: ios, windows, posix

- name: call_status_override_on_cancellation
default: true
- name: call_tracer_in_transport
default: true
- name: call_v3
Expand Down Expand Up @@ -79,8 +77,6 @@
default: false
- name: monitoring_experiment
default: true
- name: peer_state_based_framing
default: false
- name: pending_queue_cap
default: true
- name: pick_first_new
Expand Down
16 changes: 7 additions & 9 deletions src/core/lib/surface/filter_stack_call.cc
Original file line number Diff line number Diff line change
Expand Up @@ -533,15 +533,13 @@ void FilterStackCall::BatchControl::PostCompletion() {
FilterStackCall* call = call_;
grpc_error_handle error = batch_error_.get();

if (IsCallStatusOverrideOnCancellationEnabled()) {
// On the client side, if final call status is already known (i.e if this op
// includes recv_trailing_metadata) and if the call status is known to be
// OK, then disregard the batch error to ensure call->receiving_buffer_ is
// not cleared.
if (op_.recv_trailing_metadata && call->is_client() &&
call->status_error_.ok()) {
error = absl::OkStatus();
}
// On the client side, if final call status is already known (i.e if this op
// includes recv_trailing_metadata) and if the call status is known to be
// OK, then disregard the batch error to ensure call->receiving_buffer_ is
// not cleared.
if (op_.recv_trailing_metadata && call->is_client() &&
call->status_error_.ok()) {
error = absl::OkStatus();
}

GRPC_TRACE_VLOG(call, 2) << "tag:" << completion_data_.notify_tag.tag
Expand Down

0 comments on commit 4fd48b1

Please sign in to comment.