Skip to content

Commit

Permalink
use UNAVAILABLE if CDS resource is not okay
Browse files Browse the repository at this point in the history
  • Loading branch information
markdroth committed Aug 28, 2024
1 parent 5db1d75 commit 0c7bb49
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ absl::Status GcpAuthenticationFilter::Call::OnClientInitialMetadata(
// because once that happens, a new instance of this filter will be
// swapped in for subsequent calls, but *this* call is already tied
// to this filter instance, which will never see the update.
return absl::UnauthenticatedError(
return absl::UnavailableError(
absl::StrCat("GCP authentication filter: CDS resource unavailable for ",
cluster_name));
}
Expand Down
2 changes: 1 addition & 1 deletion test/core/filters/gcp_authentication_filter_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ TEST_F(GcpAuthenticationFilterTest, FailsCallIfClusterNotOkayInXdsConfig) {
service_config_call_data->SetCallAttribute(&xds_cluster_attribute);
call.Start(call.NewClientMetadata());
EXPECT_EVENT(Finished(
&call, HasMetadataResult(absl::UnauthenticatedError(absl::StrCat(
&call, HasMetadataResult(absl::UnavailableError(absl::StrCat(
"GCP authentication filter: CDS resource unavailable for ",
kClusterName)))));
Step();
Expand Down

0 comments on commit 0c7bb49

Please sign in to comment.