Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py: Don't import packages that aren't installed yet. #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

setup.py: Don't import packages that aren't installed yet. #34

wants to merge 1 commit into from

Commits on Mar 24, 2016

  1. setup.py: Don't import packages that aren't installed yet. 

    `setup.py` should never attempt to import packages that are not yet
installed, including packages from the source it is distributing.

In this case, importing `get_version()` from `geraldo.version` was causing
`reportlab` to be imported by side-effect (via `geraldo.__init__` which
imports `geraldo.graphics`, besides other modules).

However there is no guarantee that `reportlab` is already installed when
`setup.py` is run, as it is the job of `setup.py` to specify `reportlab` as a
dependency.
    @leorochael
    leorochael committed Mar 24, 2016
    Configuration menu
    Copy the full SHA
    e032936 View commit details
    Browse the repository at this point in the history