Revert "Optimize get_json_object Spark function using simdjson (5179)"

This reverts commit 1c90fc1.
marin-ma · Jul 3, 2024 · 7487845 · 7487845
1 parent 1c90fc1
commit 7487845
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 370 deletions.
diff --git a/velox/docs/functions/spark/json.rst b/velox/docs/functions/spark/json.rst
diff --git a/velox/functions/sparksql/CMakeLists.txt b/velox/functions/sparksql/CMakeLists.txt
@@ -50,8 +50,7 @@ target_link_libraries(
   velox_functions_spark_specialforms
   velox_is_null_functions
   velox_functions_util
-  Folly::folly
-  simdjson)
+  Folly::folly)
 
 set_property(TARGET velox_functions_spark PROPERTY JOB_POOL_COMPILE
                                                    high_memory_pool)

diff --git a/velox/functions/sparksql/JsonFunctions.h b/velox/functions/sparksql/JsonFunctions.h
diff --git a/velox/functions/sparksql/Register.cpp b/velox/functions/sparksql/Register.cpp
@@ -35,7 +35,6 @@
 #include "velox/functions/sparksql/DateTimeFunctions.h"
 #include "velox/functions/sparksql/Hash.h"
 #include "velox/functions/sparksql/In.h"
-#include "velox/functions/sparksql/JsonFunctions.h"
 #include "velox/functions/sparksql/LeastGreatest.h"
 #include "velox/functions/sparksql/MightContain.h"
 #include "velox/functions/sparksql/MonotonicallyIncreasingId.h"
@@ -175,9 +174,6 @@ void registerFunctions(const std::string& prefix) {
 
   registerRegexpReplace(prefix);
 
-  registerFunction<GetJsonObjectFunction, Varchar, Varchar, Varchar>(
-      {prefix + "get_json_object"});
-
   // Register string functions.
   registerFunction<sparksql::ChrFunction, Varchar, int64_t>({prefix + "chr"});
   registerFunction<AsciiFunction, int32_t, Varchar>({prefix + "ascii"});

diff --git a/velox/functions/sparksql/tests/CMakeLists.txt b/velox/functions/sparksql/tests/CMakeLists.txt
@@ -32,7 +32,6 @@ add_executable(
   ElementAtTest.cpp
   HashTest.cpp
   InTest.cpp
-  JsonFunctionsTest.cpp
   LeastGreatestTest.cpp
   MakeDecimalTest.cpp
   MakeTimestampTest.cpp