Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Handshake already has been started. #198

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/main/java/tlschannel/impl/TlsChannelImpl.java
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ public TlsChannelImpl(
private final Lock readLock = new ReentrantLock();
private final Lock writeLock = new ReentrantLock();

/** Whether the handshake was already started once. */
private boolean handWasTouched;

private volatile boolean negotiated = false;

/**
Expand Down Expand Up @@ -498,8 +501,11 @@ private void doHandshake(boolean force) throws IOException, EofException {
throw new ClosedChannelException();
}
if (force || !negotiated) {
logger.log(Level.FINEST, "Calling SSLEngine.beginHandshake()");
engine.beginHandshake();
if (!handWasTouched) {
logger.log(Level.FINEST, "Calling SSLEngine.beginHandshake()");
engine.beginHandshake();
handWasTouched = true;
}
writeAndHandshake();

if (engine.getSession().getProtocol().startsWith("DTLS")) {
Expand Down